Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Anthony Liguori
On 11/08/2011 02:36 AM, Mark Wu wrote: When I run this tool, I got two python exceptions. It turned out that both of them were caused by wrong usage. Do you think we need add validation for input to handle these cases? Definitely. Could you just send out a version of the patch with your change

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Luiz Capitulino
On Tue, 08 Nov 2011 16:36:55 +0800 Mark Wu wrote: > When I run this tool, I got two python exceptions. It turned out that > both of them were caused by wrong usage. Do you think we need add > validation for input to handle these cases? Yes. > > Thanks. > > 1. Not using '=' for path: > $

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Mark Wu
When I run this tool, I got two python exceptions. It turned out that both of them were caused by wrong usage. Do you think we need add validation for input to handle these cases? Thanks. 1. Not using '=' for path: $ ./QMP/qmp --path monitor-address Traceback (most recent call last): File

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Alon Levy
On Mon, Nov 07, 2011 at 02:39:29PM -0200, Luiz Capitulino wrote: > On Mon, 07 Nov 2011 10:35:51 -0600 > Anthony Liguori wrote: > > > On 11/07/2011 10:30 AM, Luiz Capitulino wrote: > > > On Mon, 07 Nov 2011 10:09:55 -0600 > > > Anthony Liguori wrote: > > > > > >> On 11/07/2011 10:08 AM, Luiz Capi

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 07 Nov 2011 10:35:51 -0600 Anthony Liguori wrote: > On 11/07/2011 10:30 AM, Luiz Capitulino wrote: > > On Mon, 07 Nov 2011 10:09:55 -0600 > > Anthony Liguori wrote: > > > >> On 11/07/2011 10:08 AM, Luiz Capitulino wrote: > >>> On Mon, 7 Nov 2011 09:11:15 -0600 > >>> Anthony Liguori wr

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
On 11/07/2011 10:30 AM, Luiz Capitulino wrote: On Mon, 07 Nov 2011 10:09:55 -0600 Anthony Liguori wrote: On 11/07/2011 10:08 AM, Luiz Capitulino wrote: On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: I wrote this quickly to aid in testing. It's similar to qmp-shell with a few i

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 07 Nov 2011 10:09:55 -0600 Anthony Liguori wrote: > On 11/07/2011 10:08 AM, Luiz Capitulino wrote: > > On Mon, 7 Nov 2011 09:11:15 -0600 > > Anthony Liguori wrote: > > > >> I wrote this quickly to aid in testing. It's similar to qmp-shell with a > >> few > >> important differences: >

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
On 11/07/2011 10:08 AM, Luiz Capitulino wrote: On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: I wrote this quickly to aid in testing. It's similar to qmp-shell with a few important differences: 1) It is not interactive. That makes it useful for scripting. 2) qmp-shell: (QEMU) s

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: > I wrote this quickly to aid in testing. It's similar to qmp-shell with a few > important differences: > > 1) It is not interactive. That makes it useful for scripting. > > 2) qmp-shell: > > (QEMU) set_password protocol=vnc password=

[Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
I wrote this quickly to aid in testing. It's similar to qmp-shell with a few important differences: 1) It is not interactive. That makes it useful for scripting. 2) qmp-shell: (QEMU) set_password protocol=vnc password=foo 3) qmp: $ qmp set_password --protocol=vnc --password=foo 4) Extensibl