Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-28 Thread Paolo Bonzini
Il 26/04/2014 02:46, Hani Benhabiles ha scritto: if (ambiguous) { > error_setg(errp, "Path '%s' is ambiguous.", path); > } else { > error_set(errp, QERR_DEVICE_NOT_FOUND, path); > } > Probably, you meant something like this: if (ambiguous) { error_set(errp, QERR_AMBIGUOUS_PATH, path

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-28 Thread Paolo Bonzini
Il 25/04/2014 17:51, Andreas Färber ha scritto: if (ambiguous) { error_setg(errp, "Path '%s' is ambiguous.", path); } else { error_set(errp, QERR_DEVICE_NOT_FOUND, path); } My reasoning is that an ambiguous path might deliver unpredictable results (whichever it encounters first), across

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-25 Thread Hani Benhabiles
On Fri, Apr 25, 2014 at 05:51:33PM +0200, Andreas Färber wrote: > Am 25.04.2014 17:40, schrieb Luiz Capitulino: > > On Tue, 22 Apr 2014 22:44:03 +0100 > > Hani Benhabiles wrote: > > > >> Signed-off-by: Hani Benhabiles > >> --- > >> qmp.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-25 Thread Andreas Färber
Am 25.04.2014 17:40, schrieb Luiz Capitulino: > On Tue, 22 Apr 2014 22:44:03 +0100 > Hani Benhabiles wrote: > >> Signed-off-by: Hani Benhabiles >> --- >> qmp.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/qmp.c b/qmp.c >> index 87a28f7..44a6e17 100644 >> --- a/q

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-25 Thread Luiz Capitulino
On Tue, 22 Apr 2014 22:44:03 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles > --- > qmp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/qmp.c b/qmp.c > index 87a28f7..44a6e17 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -194,11 +194,10 @@ void qmp_system_

[Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-22 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- qmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qmp.c b/qmp.c index 87a28f7..44a6e17 100644 --- a/qmp.c +++ b/qmp.c @@ -194,11 +194,10 @@ void qmp_system_wakeup(Error **errp) ObjectPropertyInfoList *qmp_qom_list(const char *path, Err