Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-07 Thread Ladi Prosek
ture. > > > From: Ladi Prosek > Sent: Monday, February 6, 2017 6:50:43 PM > To: Denis Lunev > Cc: Daniel P. Berrange; qemu-devel; Michael Roth; Alexey Kostyushko > Subject: Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl > > On Mo

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-06 Thread Denis V. Lunev
On 02/01/2017 04:41 PM, Ladi Prosek wrote: > On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange > wrote: >> On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: >>> On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange >>> wrote: On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-06 Thread Alexey Kostyushko
ature. From: Ladi Prosek Sent: Monday, February 6, 2017 6:50:43 PM To: Denis Lunev Cc: Daniel P. Berrange; qemu-devel; Michael Roth; Alexey Kostyushko Subject: Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl On Mon, Feb 6, 2017 at 4:37 PM, Denis V. Lunev wrote: > On 02

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-06 Thread Ladi Prosek
On Mon, Feb 6, 2017 at 4:37 PM, Denis V. Lunev wrote: > On 02/01/2017 04:41 PM, Ladi Prosek wrote: >> On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange >> wrote: >>> On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange wro

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-06 Thread Daniel P. Berrange
On Mon, Feb 06, 2017 at 06:37:29PM +0300, Denis V. Lunev wrote: > On 02/01/2017 04:41 PM, Ladi Prosek wrote: > > On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange > > wrote: > >> On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: > >>> On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berran

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-02 Thread Markus Armbruster
Ladi Prosek writes: > On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange > wrote: >> On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: >>> On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange >>> wrote: >>> > On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: >>> >> Analo

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Paolo Bonzini
On 01/02/2017 06:43, Eric Blake wrote: >>> It would be possible to design a ioctl API that is more usable if you >>> didn't try to do generic passthrough of arbitrary ioctl commands. Instead >>> provide a QAPI schema that uses a union to provide strongly typed arguments >>> for the ioctl commands

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Ladi Prosek
On Wed, Feb 1, 2017 at 3:43 PM, Eric Blake wrote: > On 02/01/2017 07:41 AM, Ladi Prosek wrote: > >> >> Ok, so there are two different aspects that should probably be >> separated. The actual semantics of IOCTL calls is equivalent to the >> semantics of files in general. For files it's stream in, s

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Eric Blake
On 02/01/2017 07:41 AM, Ladi Prosek wrote: > > Ok, so there are two different aspects that should probably be > separated. The actual semantics of IOCTL calls is equivalent to the > semantics of files in general. For files it's stream in, stream out > (and seeking and such). For IOCTL it's a buff

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Ladi Prosek
On Wed, Feb 1, 2017 at 12:03 PM, Daniel P. Berrange wrote: > On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: >> On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange >> wrote: >> > On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: >> >> Analogous to guest-file-read and gues

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 11:50:43AM +0100, Ladi Prosek wrote: > On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange > wrote: > > On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: > >> Analogous to guest-file-read and guest-file-write, this commit adds > >> support for issuing IOCTLs to

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Ladi Prosek
On Wed, Feb 1, 2017 at 11:20 AM, Daniel P. Berrange wrote: > On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: >> Analogous to guest-file-read and guest-file-write, this commit adds >> support for issuing IOCTLs to files in the guest. With the goal of >> abstracting away the differences

Re: [Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Daniel P. Berrange
On Wed, Feb 01, 2017 at 11:06:46AM +0100, Ladi Prosek wrote: > Analogous to guest-file-read and guest-file-write, this commit adds > support for issuing IOCTLs to files in the guest. With the goal of > abstracting away the differences between Posix ioctl() and Win32 > DeviceIoControl() to provide o

[Qemu-devel] [PATCH] qga: implement guest-file-ioctl

2017-02-01 Thread Ladi Prosek
Analogous to guest-file-read and guest-file-write, this commit adds support for issuing IOCTLs to files in the guest. With the goal of abstracting away the differences between Posix ioctl() and Win32 DeviceIoControl() to provide one unified API, the schema distinguishes between input and output buf