Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32

2015-03-30 Thread Kirk Allan
>>> > Hi Kirk, > > Am 30.03.2015 um 22:44 schrieb Kirk Allan: >> Ping. >> >> Looking for feedback anyone might have regarding this patch. > > I would recommend to make the patch smaller and the commit message more > intuitive by splitting off the configure changes into its own patch > (rememb

Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32

2015-03-30 Thread Andreas Färber
Hi Kirk, Am 30.03.2015 um 22:44 schrieb Kirk Allan: > Ping. > > Looking for feedback anyone might have regarding this patch. I would recommend to make the patch smaller and the commit message more intuitive by splitting off the configure changes into its own patch (remember to include a short co

Re: [Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32

2015-03-30 Thread Kirk Allan
Ping. Looking for feedback anyone might have regarding this patch. Thanks, Kirk >>> > For Windows guest greater than or equal to Vista/2008, _WIN32_WINNT may be > defined via the configure option with-win32-winnt=. The use of > with-win32-wint= to set _WIN32_WINNT is optional. Setting this va

[Qemu-devel] [PATCH] qga: implement qmp_guest_network_get_interfaces for win32

2015-03-16 Thread Kirk Allan
For Windows guest greater than or equal to Vista/2008, _WIN32_WINNT may be defined via the configure option with-win32-winnt=. The use of with-win32-wint= to set _WIN32_WINNT is optional. Setting this value to at least 0x0600 e.g. with-win32-wint=0x0600, provides access to the OnLinkPrefixLength