Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-17 Thread Peter Lieven
Am 03.02.2017 um 19:31 schrieb Paolo Bonzini: > > On 03/02/2017 00:20, Peter Lieven wrote: >> Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >>> On 31/01/2017 07:36, Peter Lieven wrote: the current implementation fails if we try to freeze an already frozen filesystem. This can happen if a

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 00:20, Peter Lieven wrote: > Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >> >> On 31/01/2017 07:36, Peter Lieven wrote: >>> the current implementation fails if we try to freeze an >>> already frozen filesystem. This can happen if a filesystem >>> is mounted more than once (e.g. wi

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Christian Theune
Hi, to clarify: I guess you ask about what happens when you thaw with the same condition: a filesystem that is mounted multiple times. When I created the patch initially I looked at the thaw code and found it to already expect that thaws may happen outside its control and that the error handli

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Christian Theune
Hi, > On 3 Feb 2017, at 09:20, Peter Lieven wrote: > > If you try to THAW an unfrozen FS you get EINVAL. > > The current code thaws until an error is returned. > > > So it should work as is. > > > If you feel uncomfortable with the EBUSY approach. The other idea would > > be to track all d

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Peter Lieven
Am 03.02.2017 um 09:22 schrieb Christian Theune: > Hi, > >> On 3 Feb 2017, at 09:20, Peter Lieven mailto:p...@kamp.de>> >> wrote: >> >> If you try to THAW an unfrozen FS you get EINVAL. >> >> The current code thaws until an error is returned. >> >> >> So it should work as is. >> >> >> If you feel

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-03 Thread Peter Lieven
Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: > > On 31/01/2017 07:36, Peter Lieven wrote: >> the current implementation fails if we try to freeze an >> already frozen filesystem. This can happen if a filesystem >> is mounted more than once (e.g. with a bind mount). >> >> Suggested-by: Christian Th

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-02 Thread Paolo Bonzini
On 31/01/2017 07:36, Peter Lieven wrote: > the current implementation fails if we try to freeze an > already frozen filesystem. This can happen if a filesystem > is mounted more than once (e.g. with a bind mount). > > Suggested-by: Christian Theune > Cc: qemu-sta...@nongnu.org > Signed-off-by:

[Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-01-31 Thread Peter Lieven
the current implementation fails if we try to freeze an already frozen filesystem. This can happen if a filesystem is mounted more than once (e.g. with a bind mount). Suggested-by: Christian Theune Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- qga/commands-posix.c | 5 - 1 file