Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Kirk Allan
>>> > Quoting Paolo Bonzini (2015-11-11 08:49:57) >> >> >> On 11/11/2015 15:02, Michael Roth wrote: >> >> GENERIC_READ for files >> >> = FILE_READ_DATA >> >> + FILE_READ_ATTRIBUTES >> >> + FILE_READ_EA >> >> + SYNCHRONIZE >> >> + STANDARD_RIGHTS_READ (wh

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Michael Roth
Quoting Paolo Bonzini (2015-11-11 08:49:57) > > > On 11/11/2015 15:02, Michael Roth wrote: > >> GENERIC_READ for files > >> = FILE_READ_DATA > >> + FILE_READ_ATTRIBUTES > >> + FILE_READ_EA > >> + SYNCHRONIZE > >> + STANDARD_RIGHTS_READ (which is READ_CONTRO

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Paolo Bonzini
On 11/11/2015 15:02, Michael Roth wrote: >> GENERIC_READ for files >> = FILE_READ_DATA >> + FILE_READ_ATTRIBUTES >> + FILE_READ_EA >> + SYNCHRONIZE >> + STANDARD_RIGHTS_READ (which is READ_CONTROL) >> >> GENERIC_WRITE for files >> = FILE_APPEND_DATA

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-11 Thread Michael Roth
Quoting Paolo Bonzini (2015-11-10 11:59:18) > > > On 10/11/2015 16:40, Michael Roth wrote: > > > > I hit an issue testing this though, this does fix the append > > case, but a+, ab+, a+b all imply append+read, while > > FILE_APPEND_DATA only grants append access. > > > > FILE_APPEND_DATA|GENERI

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-10 Thread Kirk Allan
>>> > > On 10/11/2015 16:40, Michael Roth wrote: >> >> I hit an issue testing this though, this does fix the append >> case, but a+, ab+, a+b all imply append+read, while >> FILE_APPEND_DATA only grants append access. >> >> FILE_APPEND_DATA|GENERIC_READ seems to work, but I'm not >> finding

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-10 Thread Paolo Bonzini
On 10/11/2015 16:40, Michael Roth wrote: > > I hit an issue testing this though, this does fix the append > case, but a+, ab+, a+b all imply append+read, while > FILE_APPEND_DATA only grants append access. > > FILE_APPEND_DATA|GENERIC_READ seems to work, but I'm not > finding much official docu

Re: [Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-10 Thread Michael Roth
Quoting Kirk Allan (2015-11-09 15:49:05) > For append file open modes, use FILE_APPEND_DATA for the desired access for > writing at the end of the file. > > Signed-off-by: Kirk Allan > --- > qga/commands-win32.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/q

[Qemu-devel] [PATCH] qga: fix append file open modes for win32

2015-11-09 Thread Kirk Allan
For append file open modes, use FILE_APPEND_DATA for the desired access for writing at the end of the file. Signed-off-by: Kirk Allan --- qga/commands-win32.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index a5306e7..0