Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

2018-11-09 Thread Michael Roth
Quoting Peter Maydell (2018-11-08 06:52:23) > The guest-agent-core.h header was missing the usual guards > against multiple inclusion; add them. > > (Spotted by lgtm.com's static analyzer.) > > Signed-off-by: Peter Maydell Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qg

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

2018-11-08 Thread Marc-André Lureau
Hi On Thu, Nov 8, 2018 at 4:52 PM Peter Maydell wrote: > > The guest-agent-core.h header was missing the usual guards > against multiple inclusion; add them. > > (Spotted by lgtm.com's static analyzer.) neat, Reviewed-by: Marc-André Lureau > > Signed-off-by: Peter Maydell > --- > qga/guest-a

Re: [Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

2018-11-08 Thread Philippe Mathieu-Daudé
On 8/11/18 13:52, Peter Maydell wrote: The guest-agent-core.h header was missing the usual guards against multiple inclusion; add them. (Spotted by lgtm.com's static analyzer.) Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- qga/gu

[Qemu-devel] [PATCH] qga: Add multiple include guard to guest-agent-core.h

2018-11-08 Thread Peter Maydell
The guest-agent-core.h header was missing the usual guards against multiple inclusion; add them. (Spotted by lgtm.com's static analyzer.) Signed-off-by: Peter Maydell --- qga/guest-agent-core.h | 5 + 1 file changed, 5 insertions(+) diff --git a/qga/guest-agent-core.h b/qga/guest-agent-cor