Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-11 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 05:29:55PM +, Peter Maydell wrote: > Explicitly include string.h to avoid warnings under MacOS X/clang > about implicit declarations of strerror() and strlen(). > > Signed-off-by: Peter Maydell > --- > I assume under Linux these are implicitly dragged in via one of the

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Stefan Weil
> On Mon, Jan 07, 2013 at 05:50:14PM +, Peter Maydell wrote: >> On 7 January 2013 17:38, Stefan Weil wrote: >> > Am 07.01.2013 18:29, schrieb Peter Maydell: >> > >> >> Explicitly include string.h to avoid warnings under MacOS X/clang >> >> about implicit declarations of strerror() and strlen()

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 05:50:14PM +, Peter Maydell wrote: > On 7 January 2013 17:38, Stefan Weil wrote: > > Am 07.01.2013 18:29, schrieb Peter Maydell: > > > >> Explicitly include string.h to avoid warnings under MacOS X/clang > >> about implicit declarations of strerror() and strlen(). > >

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Peter Maydell
On 7 January 2013 17:38, Stefan Weil wrote: > Am 07.01.2013 18:29, schrieb Peter Maydell: > >> Explicitly include string.h to avoid warnings under MacOS X/clang >> about implicit declarations of strerror() and strlen(). > Better: include qemu-common.h first and remove all > three standard include

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Stefan Weil
Am 07.01.2013 18:29, schrieb Peter Maydell: Explicitly include string.h to avoid warnings under MacOS X/clang about implicit declarations of strerror() and strlen(). Signed-off-by: Peter Maydell --- I assume under Linux these are implicitly dragged in via one of the other headers. qga/channel

[Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Peter Maydell
Explicitly include string.h to avoid warnings under MacOS X/clang about implicit declarations of strerror() and strlen(). Signed-off-by: Peter Maydell --- I assume under Linux these are implicitly dragged in via one of the other headers. qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+)