Re: [Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-14 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Markus Armbruster
Eric Blake writes: > On 08/02/2013 01:34 AM, Markus Armbruster wrote: >> Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner >> case, but broke it for another one that can't be reached in current >> code. >> > >> >> Not reachable, because we never pass lists with !list->merge_l

Re: [Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Eric Blake
On 08/02/2013 01:34 AM, Markus Armbruster wrote: > Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner > case, but broke it for another one that can't be reached in current > code. > > > Not reachable, because we never pass lists with !list->merge_lists to > qemu_opts_set_defaul

[Qemu-devel] [PATCH] qemu-option: Guard against qemu_opts_set_defaults() misuse

2013-08-02 Thread Markus Armbruster
Commit 6d4cd40 fixed qemu_opts_set_defaults() for an existing corner case, but broke it for another one that can't be reached in current code. Quote from its commit message: I believe [opts_parse()] attempts to do the following: If options don't yet exist, create new options