Re: [Qemu-devel] [PATCH] qemu-m68k: add support for interrupt masking/unmasking

2015-03-22 Thread Peter Maydell
On 22 March 2015 at 09:49, Stefan Weil wrote: > Am 22.03.2015 um 10:09 schrieb Waldemar Brodkorb: >> >> +case 0x1c: > > > Add /* SIMR */ comment behind case statement like it was done for SWIACK. > Then either add a /* fall through */ comment or a return 0 (to satisfy > static > code analyzers

Re: [Qemu-devel] [PATCH] qemu-m68k: add support for interrupt masking/unmasking

2015-03-22 Thread Peter Maydell
On 22 March 2015 at 09:09, Waldemar Brodkorb wrote: > Fixes following problem, when trying to boot linux: > qemu: hardware error: mcf_intc_write: Bad write offset 28 > > CPU #0: > D0 = 00ff A0 = 402ea5dc F0 = ( 0) > D1 = 0004 A1 = 402ea5e0 F1 = 00

Re: [Qemu-devel] [PATCH] qemu-m68k: add support for interrupt masking/unmasking

2015-03-22 Thread Stefan Weil
Technically this implementation looks reasonable. I added some remarks below. Am 22.03.2015 um 10:09 schrieb Waldemar Brodkorb: Fixes following problem, when trying to boot linux: qemu: hardware error: mcf_intc_write: Bad write offset 28 CPU #0: D0 = 00ff A0 = 402ea5dc F0 = 000

[Qemu-devel] [PATCH] qemu-m68k: add support for interrupt masking/unmasking

2015-03-22 Thread Waldemar Brodkorb
Fixes following problem, when trying to boot linux: qemu: hardware error: mcf_intc_write: Bad write offset 28 CPU #0: D0 = 00ff A0 = 402ea5dc F0 = ( 0) D1 = 0004 A1 = 402ea5e0 F1 = ( 0) D2 = 0040 A2 = 40040752 F2 = 0