Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-08 Thread Kashyap Chamarthy
On Tue, Sep 05, 2017 at 02:37:21PM -0500, Eric Blake wrote: > On 09/04/2017 08:28 AM, Kashyap Chamarthy wrote: > > On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote: > >> Hi Kashyap, > >> > >> On Mon, 09/04 13:16, Kashyap Chamarthy wrote: > > >>> The test 192 ("Test NBD export with '-incom

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-05 Thread Eric Blake
On 09/04/2017 08:28 AM, Kashyap Chamarthy wrote: > On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote: >> Hi Kashyap, >> >> On Mon, 09/04 13:16, Kashyap Chamarthy wrote: >>> The test 192 ("Test NBD export with '-incoming' (non-shared >>> storage migration use case from libvirt")) is current

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-04 Thread Kashyap Chamarthy
On Mon, Sep 04, 2017 at 03:48:12PM +0100, Daniel P. Berrange wrote: > On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote: > > The test 192 ("Test NBD export with '-incoming' (non-shared > > storage migration use case from libvirt")) is currently using HMP. > > Replace the HMP usage w

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-04 Thread Daniel P. Berrange
On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote: > The test 192 ("Test NBD export with '-incoming' (non-shared > storage migration use case from libvirt")) is currently using HMP. > Replace the HMP usage with QMP, as the upstream preference seems to be: > "Use QMP where possible,

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-04 Thread Kashyap Chamarthy
On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote: > Hi Kashyap, > > On Mon, 09/04 13:16, Kashyap Chamarthy wrote: [...] > > +dest_vm = (iotests.VM('dest').add_drive(test_img_path) > > + .add_incoming('defer')) > > Superfluous parenthesis? Yes, the paranth

Re: [Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-04 Thread Fam Zheng
Hi Kashyap, On Mon, 09/04 13:16, Kashyap Chamarthy wrote: > The test 192 ("Test NBD export with '-incoming' (non-shared > storage migration use case from libvirt")) is currently using HMP. > Replace the HMP usage with QMP, as the upstream preference seems to be: > "Use QMP where possible, unless y

[Qemu-devel] [PATCH] qemu-iotests: Make test 192 use QMP; convert it to Python

2017-09-04 Thread Kashyap Chamarthy
The test 192 ("Test NBD export with '-incoming' (non-shared storage migration use case from libvirt")) is currently using HMP. Replace the HMP usage with QMP, as the upstream preference seems to be: "Use QMP where possible, unless you're explicitly testing something related to HMP". While at it, c