Re: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

2017-07-27 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps Message-id: 1500649820-30450-1-git-send-email-kw...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

2017-07-24 Thread Kevin Wolf
Am 21.07.2017 um 17:10 hat Kevin Wolf geschrieben: > Test cases 030, 041 and 055 used to sleep for a second after calling > block-job-pause to make sure that the block job had time to actually > get into paused state. We can instead poll its status and use that one > second only as a timeout. > >

Re: [Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

2017-07-21 Thread Eric Blake
On 07/21/2017 10:10 AM, Kevin Wolf wrote: > Test cases 030, 041 and 055 used to sleep for a second after calling > block-job-pause to make sure that the block job had time to actually > get into paused state. We can instead poll its status and use that one > second only as a timeout. > > The tests

[Qemu-devel] [PATCH] qemu-iotests: Avoid unnecessary sleeps

2017-07-21 Thread Kevin Wolf
Test cases 030, 041 and 055 used to sleep for a second after calling block-job-pause to make sure that the block job had time to actually get into paused state. We can instead poll its status and use that one second only as a timeout. The tests also slept a second for checking that the block jobs