On Mon, Oct 15, 2012 at 12:07:37PM -0600, Eric Blake wrote:
> On 10/15/2012 11:29 AM, Alex Bligh wrote:
> > This patch allows qemu-img rebase to rebase an image to
> > have no backing file, as opposed to merely allowing it to
> > rebase to an existing backing file.
>
> You can already do that by r
Eric,
--On 15 October 2012 13:28:11 -0600 Eric Blake wrote:
Missing a Signed-off-by; as such, it cannot be taken as is.
New patch sent under separate cover with Signed-Off-By: line.
@@ -1580,7 +1581,7 @@ static int img_rebase(int argc, char **argv)
if (!unsafe) {
uint64_t num_s
On 10/15/2012 12:42 PM, Alex Bligh wrote:
> Eric,
>
> --On 15 October 2012 12:11:02 -0600 Eric Blake wrote:
>
>> On the other hand, if you don't use -u, then qemu-img complains:
>>
>> $ qemu-img rebase -b '' bar
>> qemu-img: Could not open new backing file ''
>>
>> So I think a better patch wo
Eric,
--On 15 October 2012 12:11:02 -0600 Eric Blake wrote:
On the other hand, if you don't use -u, then qemu-img complains:
$ qemu-img rebase -b '' bar
qemu-img: Could not open new backing file ''
So I think a better patch would be to allow rebase-by-pull to work the
same as unsafe rebase
On 10/15/2012 12:07 PM, Eric Blake wrote:
> On 10/15/2012 11:29 AM, Alex Bligh wrote:
>> This patch allows qemu-img rebase to rebase an image to
>> have no backing file, as opposed to merely allowing it to
>> rebase to an existing backing file.
>
> You can already do that by rebasing to the empty
On 10/15/2012 11:29 AM, Alex Bligh wrote:
> This patch allows qemu-img rebase to rebase an image to
> have no backing file, as opposed to merely allowing it to
> rebase to an existing backing file.
You can already do that by rebasing to the empty string. And it is
feasible (although unlikely) to
This patch allows qemu-img rebase to rebase an image to
have no backing file, as opposed to merely allowing it to
rebase to an existing backing file.
Patch below, or pull from git at:
https://github.com/abligh/qemu.git
Commit visible at:
https://github.com/abligh/qemu/commit/4d5b3b431d8dd276f4c
