Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 09:29:54AM +0100, Stefan Hajnoczi wrote: > On Tue, Dec 10, 2013 at 10:23:41PM +, Alex Bennée wrote: > > > > stefa...@redhat.com writes: > > > > > On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: > > >> 2013/11/15 Stefan Hajnoczi > > >> > > >> > On Thu, No

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-11 Thread Stefan Hajnoczi
On Tue, Dec 10, 2013 at 10:23:41PM +, Alex Bennée wrote: > > stefa...@redhat.com writes: > > > On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: > >> 2013/11/15 Stefan Hajnoczi > >> > >> > On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: > >> > > Set NOCOW flag to new

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-12-10 Thread Alex Bennée
stefa...@redhat.com writes: > On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: >> 2013/11/15 Stefan Hajnoczi >> >> > On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: >> > > Set NOCOW flag to newly created images to solve performance issues on >> > btrfs. >> > This shoul

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 12:54:59PM +0800, Chunyan Liu wrote: > 2013/11/15 Stefan Hajnoczi > > > On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: > > > Set NOCOW flag to newly created images to solve performance issues on > > btrfs. > > > > > > Btrfs has terrible performance when hosti

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-17 Thread Chunyan Liu
2013/11/15 Stefan Hajnoczi > On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: > > Set NOCOW flag to newly created images to solve performance issues on > btrfs. > > > > Btrfs has terrible performance when hosting VM images, even more when > the guest > > in those VM are also using btr

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-15 Thread Kevin Wolf
Am 15.11.2013 um 05:05 hat Chunyan Liu geschrieben: > > > > 2013/11/14 Kevin Wolf > > Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: > > Set NOCOW flag to newly created images to solve performance issues on > btrfs. > > > > Btrfs has terrible performance when hosting V

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-15 Thread Stefan Hajnoczi
On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote: > Set NOCOW flag to newly created images to solve performance issues on btrfs. > > Btrfs has terrible performance when hosting VM images, even more when the > guest > in those VM are also using btrfs as file system. One way to mitigate

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Chunyan Liu
2013/11/14 Kevin Wolf > Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: > > Set NOCOW flag to newly created images to solve performance issues on > btrfs. > > > > Btrfs has terrible performance when hosting VM images, even more when > the guest > > in those VM are also using btrfs as file sys

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bligh
--On 14 November 2013 14:23:29 + Alex Bligh wrote: Also, given FS_NOCOW_FL was only introduced in 2.6.39, should this not be guarded by #ifdef FS_NOCOW_FL (or better tested in configure in case it becomes something other than a #define in which case this test could replace #ifdef __linux

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bligh
--On 14 November 2013 10:17:26 +0100 Kevin Wolf wrote: +#ifdef __linux__ +/* set NOCOW flag to solve performance issue on fs like btrfs */ +int attr; +attr = FS_NOCOW_FL; +ioctl(fd, FS_IOC_SETFLAGS, &attr); +#endif ioctl() returning an error is ignored. This

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 10:44 hat Alex Bennée geschrieben: > > cy...@suse.com writes: > > > Set NOCOW flag to newly created images to solve performance issues on btrfs. > > > > Btrfs has terrible performance when hosting VM images, even more when the > > guest > > in those VM are also using btrfs as fi

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Alex Bennée
cy...@suse.com writes: > Set NOCOW flag to newly created images to solve performance issues on btrfs. > > Btrfs has terrible performance when hosting VM images, even more when the > guest > in those VM are also using btrfs as file system. One way to mitigate this bad > performance is to turn off

Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Kevin Wolf
Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: > Set NOCOW flag to newly created images to solve performance issues on btrfs. > > Btrfs has terrible performance when hosting VM images, even more when the > guest > in those VM are also using btrfs as file system. One way to mitigate this bad

[Qemu-devel] [PATCH] qemu-img: set nocow flag to new file

2013-11-14 Thread Chunyan Liu
Set NOCOW flag to newly created images to solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad performance is to turn off COW attributes on VM files (since ha