Re: [Qemu-devel] [PATCH] qemu-img: initialize MapEntry object

2016-02-04 Thread John Snow
On 02/04/2016 07:43 AM, Kevin Wolf wrote: > Am 04.02.2016 um 00:38 hat John Snow geschrieben: >> Commit 16b0d555 introduced an issue where we are not initializing >> has_filename for the 'next' MapEntry object, which leads to interesting >> errors in Valgrind and Clang -fsanitize=undefined both.

Re: [Qemu-devel] [PATCH] qemu-img: initialize MapEntry object

2016-02-04 Thread Kevin Wolf
Am 04.02.2016 um 00:38 hat John Snow geschrieben: > Commit 16b0d555 introduced an issue where we are not initializing > has_filename for the 'next' MapEntry object, which leads to interesting > errors in Valgrind and Clang -fsanitize=undefined both. > > Zero the stack object at allocation AND make

Re: [Qemu-devel] [PATCH] qemu-img: initialize MapEntry object

2016-02-03 Thread Fam Zheng
On Wed, 02/03 18:38, John Snow wrote: > Commit 16b0d555 introduced an issue where we are not initializing > has_filename for the 'next' MapEntry object, which leads to interesting > errors in Valgrind and Clang -fsanitize=undefined both. > > Zero the stack object at allocation AND make sure the ut

[Qemu-devel] [PATCH] qemu-img: initialize MapEntry object

2016-02-03 Thread John Snow
Commit 16b0d555 introduced an issue where we are not initializing has_filename for the 'next' MapEntry object, which leads to interesting errors in Valgrind and Clang -fsanitize=undefined both. Zero the stack object at allocation AND make sure the utility to populate the fields properly marks has_