Re: [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-26 Thread Stefan Hajnoczi
On Mon, Jul 25, 2016 at 05:58:54PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: > >> img_open_file() and img_open_opts() were printing error messages with a > >> duplicate part because of a wrong use of error_reportf

Re: [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: >> img_open_file() and img_open_opts() were printing error messages with a >> duplicate part because of a wrong use of error_reportf_err() (e.g. >> qemu-img: Could not open 'foo': Could not open 'foo': No such

Re: [Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-21 Thread Stefan Hajnoczi
On Thu, Jul 21, 2016 at 10:41:53AM +0200, Reda Sallahi wrote: > img_open_file() and img_open_opts() were printing error messages with a > duplicate part because of a wrong use of error_reportf_err() (e.g. > qemu-img: Could not open 'foo': Could not open 'foo': No such file or > directory) > > Thi

[Qemu-devel] [PATCH] qemu-img: fix error messages emitted by img_open()

2016-07-21 Thread Reda Sallahi
img_open_file() and img_open_opts() were printing error messages with a duplicate part because of a wrong use of error_reportf_err() (e.g. qemu-img: Could not open 'foo': Could not open 'foo': No such file or directory) This change uses error_report_err() instead to eliminate the duplicate part.