Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

2015-11-04 Thread Kevin Wolf
Am 03.11.2015 um 00:45 hat John Snow geschrieben: > >> diff --git a/qemu-img.c b/qemu-img.c > >> index 3025776..38b4888 100644 > >> --- a/qemu-img.c > >> +++ b/qemu-img.c > >> @@ -656,7 +656,8 @@ static void run_block_job(BlockJob *job, Error **errp) > >> > >> do { > >> aio_poll(aio

Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

2015-11-02 Thread Jeff Cody
On Mon, Nov 02, 2015 at 06:28:20PM -0500, John Snow wrote: > The mirror job doesn't update its total length until > it has already started running, so we should translate > a zero-length job-len as meaning 0%. > > Otherwise, we may get divide-by-zero faults. > > Signed-off-by: John Snow > --- >

Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

2015-11-02 Thread John Snow
On 11/02/2015 06:43 PM, Eric Blake wrote: > On 11/02/2015 04:28 PM, John Snow wrote: >> The mirror job doesn't update its total length until >> it has already started running, so we should translate >> a zero-length job-len as meaning 0%. >> >> Otherwise, we may get divide-by-zero faults. >> >> S

Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

2015-11-02 Thread Eric Blake
On 11/02/2015 04:28 PM, John Snow wrote: > The mirror job doesn't update its total length until > it has already started running, so we should translate > a zero-length job-len as meaning 0%. > > Otherwise, we may get divide-by-zero faults. > > Signed-off-by: John Snow > --- > qemu-img.c | 3 ++

[Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

2015-11-02 Thread John Snow
The mirror job doesn't update its total length until it has already started running, so we should translate a zero-length job-len as meaning 0%. Otherwise, we may get divide-by-zero faults. Signed-off-by: John Snow --- qemu-img.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g