Re: [Qemu-devel] [PATCH] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-03-25 Thread mdroth
On Fri, Mar 22, 2013 at 04:31:07PM -0400, Luiz Capitulino wrote: > Today we reset fd_counter if it wraps, but it's better to abort() > instead, as fd_counter should never reach INT64_MAX. > > Signed-off-by: Luiz Capitulino Thanks, applied to qga branch with s/resonable/reasonable/ typo fix. > -

Re: [Qemu-devel] [PATCH] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-03-22 Thread Luiz Capitulino
On Fri, 22 Mar 2013 14:44:05 -0600 Eric Blake wrote: > On 03/22/2013 02:31 PM, Luiz Capitulino wrote: > > Today we reset fd_counter if it wraps, but it's better to abort() > > instead, as fd_counter should never reach INT64_MAX. > > > > Signed-off-by: Luiz Capitulino > > --- > > qga/main.c | 8

Re: [Qemu-devel] [PATCH] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-03-22 Thread Eric Blake
On 03/22/2013 02:31 PM, Luiz Capitulino wrote: > Today we reset fd_counter if it wraps, but it's better to abort() > instead, as fd_counter should never reach INT64_MAX. > > Signed-off-by: Luiz Capitulino > --- > qga/main.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > d

[Qemu-devel] [PATCH] qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

2013-03-22 Thread Luiz Capitulino
Today we reset fd_counter if it wraps, but it's better to abort() instead, as fd_counter should never reach INT64_MAX. Signed-off-by: Luiz Capitulino --- qga/main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qga/main.c b/qga/main.c index 74ef788..5f505a2 100644 -