Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Paolo Bonzini
On 21/07/2015 10:51, Thomas Huth wrote: > On 21/07/15 09:34, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> qemu-char.c | 13 +++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/qemu-char.c b/qemu-char.c >> index b2b43c5..d956f8d 100644 >> --- a/

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Thomas Huth
On 21/07/15 09:34, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index b2b43c5..d956f8d 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2798,7 +2798,

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Nils Carlson
Agree, this is more elegant, we keep the recv in a tight loop. Acked-by: Nils Carlson On Tue, 21 Jul 2015, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- qemu-char.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b2b43

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Amit Shah
On (Tue) 21 Jul 2015 [09:34:29], Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Paolo Bonzini
On 21/07/2015 10:10, Peter Maydell wrote: > On 21 July 2015 at 08:34, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> qemu-char.c | 13 +++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/qemu-char.c b/qemu-char.c >> index b2b43c5..d956f8d 100644

Re: [Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Peter Maydell
On 21 July 2015 at 08:34, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index b2b43c5..d956f8d 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -2798,7

[Qemu-devel] [PATCH] qemu-char: handle EINTR for TCP character devices

2015-07-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-char.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b2b43c5..d956f8d 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2798,7 +2798,10 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char