Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread mdroth
On Thu, May 30, 2013 at 03:24:14PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Thu, May 30, 2013 at 02:35:37PM -0500, Anthony Liguori wrote: > >> mdroth writes: > >> > >> > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: > >> >> Michael Roth writes: > >> >> > >> >

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread Anthony Liguori
mdroth writes: > On Thu, May 30, 2013 at 02:35:37PM -0500, Anthony Liguori wrote: >> mdroth writes: >> >> > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: >> >> Michael Roth writes: >> >> >> >> > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and >> >> > it

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread mdroth
On Thu, May 30, 2013 at 02:35:37PM -0500, Anthony Liguori wrote: > mdroth writes: > > > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: > >> Michael Roth writes: > >> > >> > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and > >> > it was issued as a bottom-ha

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread Anthony Liguori
mdroth writes: > On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: >> Michael Roth writes: >> >> > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and >> > it was issued as a bottom-half: >> > >> > 86e94dea5b740dad65446c857f6959eae43e0ba6 >> > >> > AFAICT the onl

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread mdroth
On Thu, May 30, 2013 at 11:55:56AM -0500, Anthony Liguori wrote: > Michael Roth writes: > > > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and > > it was issued as a bottom-half: > > > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > > > AFAICT the only reason this was ever done

Re: [Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-30 Thread Anthony Liguori
Michael Roth writes: > When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and > it was issued as a bottom-half: > > 86e94dea5b740dad65446c857f6959eae43e0ba6 > > AFAICT the only reason this was ever done in a BH was because it was > initially used to to issue a CHR_EVENT_RESET when w

[Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-29 Thread Michael Roth
When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 AFAICT the only reason this was ever done in a BH was because it was initially used to to issue a CHR_EVENT_RESET when we initialized the monitor, and we w