Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-17 Thread Paolo Bonzini
Il 17/04/2013 17:36, Hans de Goede ha scritto: >>> >> >> I'm not sure why all users of qemu_chr_fe_add_watch believe that the >> watch will be one-shot. This is definitely not what g_io_create_watch >> does... > > It is supposed to depend on the return value of the callback, if you > return False

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-17 Thread Hans de Goede
Ji, On 04/16/2013 11:34 AM, Paolo Bonzini wrote: Il 16/04/2013 11:15, Gerd Hoffmann ha scritto: On 04/10/13 15:23, Paolo Bonzini wrote: After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, remo

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 11:15, Gerd Hoffmann ha scritto: > On 04/10/13 15:23, Paolo Bonzini wrote: >> After attaching the source, we have to remove the reference we hold >> to it, because we do not hold anymore a pointer to the source. >> >> If we do not do this, removing the source will not finalize it and

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-16 Thread Gerd Hoffmann
On 04/10/13 15:23, Paolo Bonzini wrote: > After attaching the source, we have to remove the reference we hold > to it, because we do not hold anymore a pointer to the source. > > If we do not do this, removing the source will not finalize it and > will not drop the "real" I/O watch source. > > Th

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-15 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 11:24, Amit Shah ha scritto: > Can you try multiple writes from the guest? At least 3-4? QEMU > doesn't detect a backend getting closed right away (another bug), so > the freeze doesn't trigger til qemu detects there's no chardev > anymore. All writes after the second will hang and

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-12 Thread Amit Shah
On (Thu) 11 Apr 2013 [10:58:30], Paolo Bonzini wrote: > Il 10/04/2013 19:59, Amit Shah ha scritto: > > On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote: > >> After attaching the source, we have to remove the reference we hold > >> to it, because we do not hold anymore a pointer to the source. >

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-11 Thread Paolo Bonzini
Il 10/04/2013 19:59, Amit Shah ha scritto: > On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote: >> After attaching the source, we have to remove the reference we hold >> to it, because we do not hold anymore a pointer to the source. >> >> If we do not do this, removing the source will not finali

Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-10 Thread Amit Shah
On (Wed) 10 Apr 2013 [15:23:27], Paolo Bonzini wrote: > After attaching the source, we have to remove the reference we hold > to it, because we do not hold anymore a pointer to the source. > > If we do not do this, removing the source will not finalize it and > will not drop the "real" I/O watch s

[Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix

2013-04-10 Thread Paolo Bonzini
After attaching the source, we have to remove the reference we hold to it, because we do not hold anymore a pointer to the source. If we do not do this, removing the source will not finalize it and will not drop the "real" I/O watch source. This showed up when backporting the new flow control pat