Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors

2011-10-31 Thread Zhi Yong Wu
On Mon, Oct 31, 2011 at 02:11:00PM +, Stefan Hajnoczi wrote: >From: Stefan Hajnoczi >To: Zhi Yong Wu >Cc: Kevin Wolf , Zhi Yong Wu , > qemu-devel@nongnu.org, stefa...@linux.vnet.ibm.com >Content-Type: text/plain; charset=ISO-8859-1 >x-cbid: 11103114-6148---00CC1760 >X-IBM-ISS-Spam

Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors

2011-10-31 Thread Stefan Hajnoczi
On Mon, Oct 31, 2011 at 8:25 AM, Zhi Yong Wu wrote: > On Mon, Oct 31, 2011 at 4:10 PM, Kevin Wolf wrote: >> Am 31.10.2011 04:01, schrieb Zhi Yong Wu: >>> It is better to use qiov.size in qed-table.c to get nb_sectors than >>> iov.iov_len. >>> >>> Signed-off-by: Zhi Yong Wu >> >> The commit mess

Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors

2011-10-31 Thread Zhi Yong Wu
On Mon, Oct 31, 2011 at 4:10 PM, Kevin Wolf wrote: > Am 31.10.2011 04:01, schrieb Zhi Yong Wu: >> It is better to use qiov.size in qed-table.c to get nb_sectors than >> iov.iov_len. >> >> Signed-off-by: Zhi Yong Wu > > The commit message should probably say why it's better. Not saying > otherwis

Re: [Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors

2011-10-31 Thread Kevin Wolf
Am 31.10.2011 04:01, schrieb Zhi Yong Wu: > It is better to use qiov.size in qed-table.c to get nb_sectors than > iov.iov_len. > > Signed-off-by: Zhi Yong Wu The commit message should probably say why it's better. Not saying otherwise, but I can't see the different at the first sight. Kevin

[Qemu-devel] [PATCH] qed: adjust the way to get nb_sectors

2011-10-30 Thread Zhi Yong Wu
It is better to use qiov.size in qed-table.c to get nb_sectors than iov.iov_len. Signed-off-by: Zhi Yong Wu --- block/qed-table.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qed-table.c b/block/qed-table.c index f31f9ff..8ee8443 100644 --- a/block/qed-tabl