Re: [Qemu-devel] [PATCH] qdict: fix unbounded stack for qdict_array_entries

2016-03-21 Thread Peter Xu
On Mon, Mar 21, 2016 at 02:58:25PM -0600, Eric Blake wrote: > On 03/09/2016 06:36 PM, Peter Xu wrote: > > Sorry to forgot CCing Eric/Markus/Kevin. > > > > This patch title is not correct, which should be: > > > > "Fix unbounded stack warning for qdict_array_entries" > > Keep the 'qdict:' prefix,

Re: [Qemu-devel] [PATCH] qdict: fix unbounded stack for qdict_array_entries

2016-03-21 Thread Eric Blake
On 03/09/2016 06:36 PM, Peter Xu wrote: > Sorry to forgot CCing Eric/Markus/Kevin. > > This patch title is not correct, which should be: > > "Fix unbounded stack warning for qdict_array_entries" Keep the 'qdict:' prefix, but yes, adding "warning" helps the commit message. > > Do I need to re-s

Re: [Qemu-devel] [PATCH] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Peter Xu
Sorry to forgot CCing Eric/Markus/Kevin. This patch title is not correct, which should be: "Fix unbounded stack warning for qdict_array_entries" Do I need to re-send with the same content? I'm using g_strdup_printf() here, considering it's most convenient, safe, and as long as it's called rarel

[Qemu-devel] [PATCH] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Peter Xu
Signed-off-by: Peter Xu --- qobject/qdict.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 9833bd0..9188a87 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -704,19 +704,16 @@ int qdict_array_entries(QDict *src, con