Re: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-24 Thread Markus Armbruster
Jan Kiszka writes: > On 2012-01-21 17:36, Andreas Färber wrote: >> Am 21.01.2012 14:43, schrieb Jan Kiszka: >>> By using strncasecmp, we allow for arbitrary characters after the >>> "on"/"off" string. Fix this by switching to strcasecmp. >>> >>> Signed-off-by: Jan Kiszka >> >> Reviewed-by: Andr

Re: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Jan Kiszka
On 2012-01-21 17:36, Andreas Färber wrote: > Am 21.01.2012 14:43, schrieb Jan Kiszka: >> By using strncasecmp, we allow for arbitrary characters after the >> "on"/"off" string. Fix this by switching to strcasecmp. >> >> Signed-off-by: Jan Kiszka > > Reviewed-by: Andreas Färber > > An alternativ

Re: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Andreas Färber
Am 21.01.2012 14:43, schrieb Jan Kiszka: > By using strncasecmp, we allow for arbitrary characters after the > "on"/"off" string. Fix this by switching to strcasecmp. > > Signed-off-by: Jan Kiszka Reviewed-by: Andreas Färber An alternative might be to increase the char count by one. For a cons

[Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Jan Kiszka
By using strncasecmp, we allow for arbitrary characters after the "on"/"off" string. Fix this by switching to strcasecmp. Signed-off-by: Jan Kiszka --- hw/qdev-properties.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c ind