Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties

2016-05-18 Thread Eduardo Habkost
On Thu, May 12, 2016 at 06:22:36PM +0200, Andreas Färber wrote: > Am 12.05.2016 um 14:26 schrieb Eduardo Habkost: > > On Fri, Jan 29, 2016 at 12:15:12PM -0200, Eduardo Habkost wrote: > >> On Thu, Jan 28, 2016 at 07:01:12PM +0200, Michael S. Tsirkin wrote: > >>> On Thu, Jan 28, 2016 at 01:02:26PM -0

Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties

2016-05-12 Thread Eduardo Habkost
On Fri, Jan 29, 2016 at 12:15:12PM -0200, Eduardo Habkost wrote: > On Thu, Jan 28, 2016 at 07:01:12PM +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 28, 2016 at 01:02:26PM -0200, Eduardo Habkost wrote: > > > If the same GlobalProperty struct is registered twice, the list > > > entry gets corrupte

Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties

2016-01-29 Thread Eduardo Habkost
On Thu, Jan 28, 2016 at 07:01:12PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 28, 2016 at 01:02:26PM -0200, Eduardo Habkost wrote: > > If the same GlobalProperty struct is registered twice, the list > > entry gets corrupted, making tqe_next points to itself, and > > qdev_prop_set_globals() gets

Re: [Qemu-devel] [PATCH] qdev: Use GList for global properties

2016-01-28 Thread Michael S. Tsirkin
On Thu, Jan 28, 2016 at 01:02:26PM -0200, Eduardo Habkost wrote: > If the same GlobalProperty struct is registered twice, the list > entry gets corrupted, making tqe_next points to itself, and > qdev_prop_set_globals() gets stuck in a loop. The bug can be > easily reproduced by running: > > $ qe

[Qemu-devel] [PATCH] qdev: Use GList for global properties

2016-01-28 Thread Eduardo Habkost
If the same GlobalProperty struct is registered twice, the list entry gets corrupted, making tqe_next points to itself, and qdev_prop_set_globals() gets stuck in a loop. The bug can be easily reproduced by running: $ qemu-system-x86_64 -rtc-td-hack -rtc-td-hack Change global_props to use GList