Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Peter Crosthwaite
On Thu, Feb 6, 2014 at 2:46 AM, Andreas Färber wrote: > Am 05.02.2014 17:38, schrieb Paolo Bonzini: >> Il 05/02/2014 15:09, Andreas Färber ha scritto: >>> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >>> index 82a9123..14c8765 100644 >>> --- a/hw/core/qdev.c >>> +++ b/hw/core/qdev.c >>> @@ -131,21

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Andreas Färber
Am 05.02.2014 17:46, schrieb Andreas Färber: > Am 05.02.2014 17:38, schrieb Paolo Bonzini: >> Il 05/02/2014 15:09, Andreas Färber ha scritto: >>> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >>> index 82a9123..14c8765 100644 >>> --- a/hw/core/qdev.c >>> +++ b/hw/core/qdev.c >>> @@ -131,21 +131,27 @

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Andreas Färber
Am 05.02.2014 17:38, schrieb Paolo Bonzini: > Il 05/02/2014 15:09, Andreas Färber ha scritto: >> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >> index 82a9123..14c8765 100644 >> --- a/hw/core/qdev.c >> +++ b/hw/core/qdev.c >> @@ -131,21 +131,27 @@ DeviceState *qdev_create(BusState *bus, const >> ch

Re: [Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 15:09, Andreas Färber ha scritto: diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 82a9123..14c8765 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -131,21 +131,27 @@ DeviceState *qdev_create(BusState *bus, const char *name) DeviceState *qdev_try_create(BusState *bus, const c

[Qemu-devel] [PATCH] qdev: Fix qdev_try_create() for bus-less devices

2014-02-05 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) made NAND a device rather than SysBus device. This led to all boards using the device (akita, borzoi, spitz, terrier, tosa, axis-dev88) crashing on "info qtree". The difference to the bus-less ARMCPU is that the devi