Re: [Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-10 Thread Igor Mammedov
On Sun, 9 Mar 2014 18:55:05 +0200 "Michael S. Tsirkin" wrote: > On Sun, Mar 09, 2014 at 05:48:57PM +0100, Andreas Färber wrote: > > Am 09.03.2014 17:40, schrieb Michael S. Tsirkin: > > > On Fri, Mar 07, 2014 at 07:13:18PM +0100, Andreas Färber wrote: > > >> Commit 1a37eca107cece3ed454bae29eef0bd1

Re: [Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-09 Thread Michael S. Tsirkin
On Sun, Mar 09, 2014 at 05:48:57PM +0100, Andreas Färber wrote: > Am 09.03.2014 17:40, schrieb Michael S. Tsirkin: > > On Fri, Mar 07, 2014 at 07:13:18PM +0100, Andreas Färber wrote: > >> Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add > >> "hotpluggable" property to Device) added a prop

Re: [Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-09 Thread Andreas Färber
Am 09.03.2014 17:40, schrieb Michael S. Tsirkin: > On Fri, Mar 07, 2014 at 07:13:18PM +0100, Andreas Färber wrote: >> Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add >> "hotpluggable" property to Device) added a property "hotpluggable" to >> each device, with its getter accessing parent_

Re: [Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-09 Thread Michael S. Tsirkin
On Fri, Mar 07, 2014 at 07:13:18PM +0100, Andreas Färber wrote: > Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add > "hotpluggable" property to Device) added a property "hotpluggable" to > each device, with its getter accessing parent_bus->allow_hotplug. > > Add a NULL check. > > Cc: Ig

[Qemu-devel] [PATCH] qdev: Fix bus dependency of DeviceState::hotpluggable getter

2014-03-07 Thread Andreas Färber
Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add "hotpluggable" property to Device) added a property "hotpluggable" to each device, with its getter accessing parent_bus->allow_hotplug. Add a NULL check. Cc: Igor Mammedov Signed-off-by: Andreas Färber --- hw/core/qdev.c | 3 ++- 1 fil