Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Osier Yang writes: > On 2013年03月08日 16:50, Markus Armbruster wrote: >> Osier Yang writes: >> >>> I'm wondering if it could be long time to wait for the device_del >>> completes (AFAIK from previous bugs, it can be, though it should be >>> fine for most of the cases). If it's too long, it will be

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Osier Yang
On 2013年03月08日 16:50, Markus Armbruster wrote: Osier Yang writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's too long, it will be a problem for management, because it

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Osier Yang
On 2013年03月08日 17:25, Jiri Denemark wrote: On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: Osier Yang writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Jiri Denemark
On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: > Osier Yang writes: > > > I'm wondering if it could be long time to wait for the device_del > > completes (AFAIK from previous bugs, it can be, though it should be > > fine for most of the cases). If it's too long, it will be a pro

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Osier Yang writes: > I'm wondering if it could be long time to wait for the device_del > completes (AFAIK from previous bugs, it can be, though it should be > fine for most of the cases). If it's too long, it will be a problem > for management, because it looks like hanging. We can have a timeout

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Osier Yang
On 2013年03月08日 03:15, Michael S. Tsirkin wrote: On Thu, Mar 07, 2013 at 08:00:29PM +0100, Andreas Färber wrote: Am 07.03.2013 19:12, schrieb Michael S. Tsirkin: On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Thu, Mar 07, 2013 at 03:14:15PM

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 09:18:48PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: > >> >> And

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: >> >> Andreas Färber writes: >> >> >> >> > Am 07.03.2013 11:07, schrieb Michael S. Tsirk

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 08:00:29PM +0100, Andreas Färber wrote: > Am 07.03.2013 19:12, schrieb Michael S. Tsirkin: > > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >>> On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Andreas Färber
Am 07.03.2013 19:12, schrieb Michael S. Tsirkin: > On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: Andreas Färber writes: > Am 07.03.2013 11:07, schrieb Micha

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 06:23:46PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: > >> Andreas Färber writes: > >> > >> > Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: > >> >> On Thu, Mar 07, 2013 at 10:

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: >> Andreas Färber writes: >> >> > Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: >> >> On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: >> >>> "Michael S. Tsirkin" writes: >> >

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 03:14:15PM +0100, Markus Armbruster wrote: > Andreas Färber writes: > > > Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: > >> On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > On Wed, Mar 06, 2013 at 02:57

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
Andreas Färber writes: > Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: >> On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: > Am 06.03.2013 14:00, schrieb Michael S.

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Andreas Färber
Am 07.03.2013 11:07, schrieb Michael S. Tsirkin: > On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >>> On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > libvirt has a lon

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 10:55:23AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: > >> Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > >> > libvirt has a long-standing bug: when removing the device, > >> > it

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: >> Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: >> > libvirt has a long-standing bug: when removing the device, >> > it can request removal but does not know when does the >> > removal complete. Add

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-07 Thread Markus Armbruster
Eric Blake writes: > [adding libvirt] > > On 03/06/2013 07:52 AM, Paolo Bonzini wrote: >> Il 06/03/2013 15:44, Eric Blake ha scritto: >>> Question - if libvirt misses the event (for example, if libvirtd >>> requests a remove, but then gets restarted, and the event arrives before >>> libvirtd is b

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Eric Blake
[adding libvirt] On 03/06/2013 07:52 AM, Paolo Bonzini wrote: > Il 06/03/2013 15:44, Eric Blake ha scritto: >> Question - if libvirt misses the event (for example, if libvirtd >> requests a remove, but then gets restarted, and the event arrives before >> libvirtd is back up), is there a way to pol

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Paolo Bonzini
Il 06/03/2013 15:44, Eric Blake ha scritto: > Question - if libvirt misses the event (for example, if libvirtd > requests a remove, but then gets restarted, and the event arrives before > libvirtd is back up), is there a way to poll whether the the removal has > completed? The event is great to mi

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 07:44:32AM -0700, Eric Blake wrote: > On 03/06/2013 06:00 AM, Michael S. Tsirkin wrote: > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when does the > > removal complete. Add an event so we can fix this in a robust

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Eric Blake
On 03/06/2013 06:00 AM, Michael S. Tsirkin wrote: > libvirt has a long-standing bug: when removing the device, > it can request removal but does not know when does the > removal complete. Add an event so we can fix this in a robust way. s/complete/completes/ > > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
On Wed, Mar 06, 2013 at 02:57:22PM +0100, Andreas Färber wrote: > Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > > libvirt has a long-standing bug: when removing the device, > > it can request removal but does not know when does the > > removal complete. Add an event so we can fix this in a rob

Re: [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Andreas Färber
Am 06.03.2013 14:00, schrieb Michael S. Tsirkin: > libvirt has a long-standing bug: when removing the device, > it can request removal but does not know when does the > removal complete. Add an event so we can fix this in a robust way. > > Signed-off-by: Michael S. Tsirkin Sounds like a good ide

[Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-06 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when does the removal complete. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index b2698e4..ec5b810 10064