Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2019 17:56, Kevin Wolf wrote: > Am 25.01.2019 um 15:36 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: >>> Results on tmpfs: >>> cached is lseek cache by Kevin >>> detect is this patch >>> no lseek is just remove block_status query on bs-

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-25 Thread Kevin Wolf
Am 25.01.2019 um 15:36 hat Vladimir Sementsov-Ogievskiy geschrieben: > 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > > Results on tmpfs: > > cached is lseek cache by Kevin > > detect is this patch > > no lseek is just remove block_status query on bs->file->bs in > > bdrv_co_bloc

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-25 Thread Kevin Wolf
Am 22.03.2019 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > > drv_co_block_status digs bs->file for additional, more accurate search > > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > > > This accuracy is not

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-22 Thread Vladimir Sementsov-Ogievskiy
25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes and

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-02-26 Thread Vladimir Sementsov-Ogievskiy
ping 06.02.2019 15:30, Vladimir Sementsov-Ogievskiy wrote: > ping. > > Finally, what about this? > > 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: >> drv_co_block_status digs bs->file for additional, more accurate search >> for hole inside region, reported as DATA by bs since 5daa74a6ebc

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
ping. Finally, what about this? 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, q

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-01-25 Thread Vladimir Sementsov-Ogievskiy
25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes and

[Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-01-25 Thread Vladimir Sementsov-Ogievskiy
drv_co_block_status digs bs->file for additional, more accurate search for hole inside region, reported as DATA by bs since 5daa74a6ebc. This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 knows, where are holes and where is data. But every block_status request calls lseek additi