Re: [Qemu-devel] [PATCH] qcow2: Remove abort on free_clusters failure

2010-04-27 Thread Kevin Wolf
Am 27.04.2010 14:52, schrieb Stefan Hajnoczi: > On Tue, Apr 27, 2010 at 11:35 AM, Kevin Wolf wrote: >> --- a/block/qcow2-refcount.c >> +++ b/block/qcow2-refcount.c >> @@ -638,7 +638,7 @@ void qcow2_free_clusters(BlockDriverState *bs, >> ret = update_refcount(bs, offset, size, -1); >> if (r

Re: [Qemu-devel] [PATCH] qcow2: Remove abort on free_clusters failure

2010-04-27 Thread Stefan Hajnoczi
On Tue, Apr 27, 2010 at 11:35 AM, Kevin Wolf wrote: > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -638,7 +638,7 @@ void qcow2_free_clusters(BlockDriverState *bs, >     ret = update_refcount(bs, offset, size, -1); >     if (ret < 0) { >         fprintf(stderr, "qcow2_free_clust

[Qemu-devel] [PATCH] qcow2: Remove abort on free_clusters failure

2010-04-27 Thread Kevin Wolf
While it's true that during regular operation free_clusters failure would be a bug, an I/O error can always happen. There's no need to kill the VM, the worst thing that can happen (and it will) is that we leak some clusters. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c |2 +- 1 files