Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Kevin Wolf
Am 28.02.2012 11:00, schrieb Stefan Hajnoczi: > On Tue, Feb 28, 2012 at 9:47 AM, Kevin Wolf wrote: >> Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: >>> On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: +if (ext.len > 65536) { +error_report("Header extension larger t

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Stefan Hajnoczi
On Tue, Feb 28, 2012 at 9:47 AM, Kevin Wolf wrote: > Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: >> On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: >>> +        if (ext.len > 65536) { >>> +            error_report("Header extension larger than 64k - this looks >>> wrong"); >>> +            

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Kevin Wolf
Am 28.02.2012 10:33, schrieb Stefan Hajnoczi: > On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: >> +if (ext.len > 65536) { >> +error_report("Header extension larger than 64k - this looks >> wrong"); >> +return -ENOTSUP; >> +} > > This is an implementati

Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-28 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf wrote: > +        if (ext.len > 65536) { > +            error_report("Header extension larger than 64k - this looks > wrong"); > +            return -ENOTSUP; > +        } This is an implementation limit and not in the spec, but I think it's reasonable

[Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions

2012-02-27 Thread Kevin Wolf
Image files that make qemu-img info read several gigabytes into the unknown header extensions list are bad. Just fail opening the image if an extension claims to be large. Signed-off-by: Kevin Wolf --- block/qcow2.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/blo