Re: [Qemu-devel] [PATCH] qcow2: Don't shadow return value

2013-09-24 Thread Kevin Wolf
Am 24.09.2013 um 13:50 hat Max Reitz geschrieben: > When trying to update the refcounts for a snapshot, the return value of > update_refcount on a compressed cluster was pretty much ignored, > cancelling the update on error but returning 0. This is caused by an > inner "ret" variable shadowing the

[Qemu-devel] [PATCH] qcow2: Don't shadow return value

2013-09-24 Thread Max Reitz
When trying to update the refcounts for a snapshot, the return value of update_refcount on a compressed cluster was pretty much ignored, cancelling the update on error but returning 0. This is caused by an inner "ret" variable shadowing the outer one (the latter is used in the return statement). S