Re: [Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-17 Thread Eduardo Habkost
On Mon, Jul 17, 2017 at 09:45:01AM -0500, Eric Blake wrote: > On 07/14/2017 03:33 PM, Eduardo Habkost wrote: > > The conflict check added by commit c0644771 ("qapi: Reject > > alternates that can't work with keyval_parse()") doesn't work > > with the following declaration: > > > > { 'alternate':

Re: [Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-17 Thread Eric Blake
On 07/14/2017 03:33 PM, Eduardo Habkost wrote: > The conflict check added by commit c0644771 ("qapi: Reject > alternates that can't work with keyval_parse()") doesn't work > with the following declaration: > > { 'alternate': 'Alt', > 'data': { 'one': 'bool', > 'two': 'str' } }

Re: [Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-14 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170714203313.31041-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH] qapi: Fix error handling code on

[Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-14 Thread Eduardo Habkost
The conflict check added by commit c0644771 ("qapi: Reject alternates that can't work with keyval_parse()") doesn't work with the following declaration: { 'alternate': 'Alt', 'data': { 'one': 'bool', 'two': 'str' } } It crashes with: Traceback (most recent call last): F