Re: [Qemu-devel] [PATCH] qapi: Fix crash on missing alternate member of QAPI struct

2016-06-16 Thread Kashyap Chamarthy
On Wed, Jun 15, 2016 at 11:37:51AM -0600, Eric Blake wrote: > If a QAPI struct has a mandatory alternate member which is not > present on input, the input visitor reports an error for the > missing alternate without setting the discriminator, but the > cleanup code for the struct still tries to use

Re: [Qemu-devel] [PATCH] qapi: Fix crash on missing alternate member of QAPI struct

2016-06-16 Thread Markus Armbruster
Eric Blake writes: > If a QAPI struct has a mandatory alternate member which is not > present on input, the input visitor reports an error for the > missing alternate without setting the discriminator, but the > cleanup code for the struct still tries to use the dealloc > visitor to clean up the

[Qemu-devel] [PATCH] qapi: Fix crash on missing alternate member of QAPI struct

2016-06-15 Thread Eric Blake
If a QAPI struct has a mandatory alternate member which is not present on input, the input visitor reports an error for the missing alternate without setting the discriminator, but the cleanup code for the struct still tries to use the dealloc visitor to clean up the alternate. Commit dbf11922 cha