Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 17:45, Eric Blake wrote: > On 02/02/2016 10:26 AM, Peter Maydell wrote: >> On 2 February 2016 at 14:51, Eric Blake wrote: >>> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor >>> pollution of '#define mips 1'. Treat it the same way as we do for >>> the po

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Eric Blake
On 02/02/2016 10:26 AM, Peter Maydell wrote: > On 2 February 2016 at 14:51, Eric Blake wrote: >> Commit 86f4b687 broke compilation on MIPS, which has a preprocessor >> pollution of '#define mips 1'. Treat it the same way as we do for >> the pollution with 'unix', so that QMP remains backwards com

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Peter Maydell
On 2 February 2016 at 14:51, Eric Blake wrote: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to use the alt

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to use the alternative 'q_mips' spelling.

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread James Hogan
On Tue, Feb 02, 2016 at 07:51:41AM -0700, Eric Blake wrote: > Commit 86f4b687 broke compilation on MIPS, which has a preprocessor > pollution of '#define mips 1'. Treat it the same way as we do for > the pollution with 'unix', so that QMP remains backwards compatible > and only the C code needs to

[Qemu-devel] [PATCH] qapi: Fix compilation failure on MIPS

2016-02-02 Thread Eric Blake
Commit 86f4b687 broke compilation on MIPS, which has a preprocessor pollution of '#define mips 1'. Treat it the same way as we do for the pollution with 'unix', so that QMP remains backwards compatible and only the C code needs to use the alternative 'q_mips' spelling. CC: James Hogan Signed-off