Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 18:25, Markus Armbruster wrote: > With "make check" fixed: > Reviewed-by: Markus Armbruster > > I'm happy to take it through my tree when it's ready (tell me then), but > it might be easier to take it along whatever fixes "make check". OK; I'm currently doing the testing bi

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 February 2016 at 17:39, Markus Armbruster wrote: >> Eric Blake writes: >> >>> As a followup to commit cbf2115, clean up the includes in files >>> generated by QAPI so that osdep.h is included first in .c files, >>> and headers which it implies are not included manua

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 17:39, Markus Armbruster wrote: > Eric Blake writes: > >> As a followup to commit cbf2115, clean up the includes in files >> generated by QAPI so that osdep.h is included first in .c files, >> and headers which it implies are not included manually. This >> patch is done man

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Markus Armbruster
Eric Blake writes: > As a followup to commit cbf2115, clean up the includes in files > generated by QAPI so that osdep.h is included first in .c files, > and headers which it implies are not included manually. This > patch is done manually, since Coccinelle (and therefore > scripts/clean-include

[Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Eric Blake
As a followup to commit cbf2115, clean up the includes in files generated by QAPI so that osdep.h is included first in .c files, and headers which it implies are not included manually. This patch is done manually, since Coccinelle (and therefore scripts/clean-includes) doesn't see into the generat