Re: [Qemu-devel] [PATCH] pxa27x: Add 'const' attribute to keyboard maps

2013-12-22 Thread Peter Maydell
On 22 December 2013 14:22, Stefan Weil wrote: > The mapping is a hardware feature, so it is relatively constant. This is true but not particularly relevant to whether we should be marking the structs and parameters as 'const' or not. Still, the change is good, so Reviewed-by: Peter Maydell tha

[Qemu-devel] [PATCH] pxa27x: Add 'const' attribute to keyboard maps

2013-12-22 Thread Stefan Weil
The mapping is a hardware feature, so it is relatively constant. Signed-off-by: Stefan Weil --- hw/arm/mainstone.c |2 +- hw/arm/z2.c |2 +- hw/input/pxa2xx_keypad.c |6 +++--- include/hw/arm/pxa.h |4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-)