Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread Wei Huang
On 03/16/2017 07:04 AM, Alex Bennée wrote: > > Anishka0107 writes: > >> To prevent bitrot of the format string of the debug statement, files with >> conditional debug statements should ensure that printf is compiled always, >> and enclosed within if(0) statements and not in #ifdef. >>

Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread Alex Bennée
Anishka0107 writes: > To prevent bitrot of the format string of the debug statement, files with > conditional debug statements should ensure that printf is compiled always, > and enclosed within if(0) statements and not in #ifdef. > > Signed-off-by: Anishka Gupta > --- > include/hw/uni

Re: [Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] puv3: always compile-check debug printf Message-id: 1489638621-31978-1-git-send-email-rimjhim0...@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash BASE

[Qemu-devel] [PATCH] puv3: always compile-check debug printf

2017-03-16 Thread Anishka0107
To prevent bitrot of the format string of the debug statement, files with conditional debug statements should ensure that printf is compiled always, and enclosed within if(0) statements and not in #ifdef. Signed-off-by: Anishka Gupta --- include/hw/unicore32/puv3.h | 14 +- 1