Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

2016-11-28 Thread Gerd Hoffmann
Hi, > +/* the definition of MOUSE_EVENT_WHEELUP/MOUSE_EVENT_WHEELDN > + * is ambiguous since ps2_mouse_send_packet expects the bits > + * for buttons 4 and 5 at s->mouse_buttons & 0x18 which > + * matches MOUSE_EVENT_WHEELUP/MOUSE_EVENT_WHEELDN */ > static const int bmap[IN

Re: [Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

2016-11-28 Thread Eric Blake
On 11/24/2016 07:16 AM, Fabian Lesniak wrote: > This patch introduces the SIDE and EXTRA mouse buttons and implements > appropriate event generation for gtk and input-linux input methods. > > The naming was borrowed from evdev since it is more descriptive than > BUTTON4/5. > > Note that the guest

[Qemu-devel] [PATCH] ps2: add support for mice with extra/side buttons

2016-11-24 Thread Fabian Lesniak
This patch introduces the SIDE and EXTRA mouse buttons and implements appropriate event generation for gtk and input-linux input methods. The naming was borrowed from evdev since it is more descriptive than BUTTON4/5. Note that the guest has to switch the ps2 mouse into IMEX mode, otherwise even