Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-27 Thread OGAWA Hirofumi
Hervé Poussineau writes: > [from hw/input/ps2.c] >>> Can you also add the keycodes for scancode set 1: >>> +[Q_KEY_CODE_HIRAGANA] = 0x70, >>> +[Q_KEY_CODE_HENKAN] = 0x79, >>> +[Q_KEY_CODE_YEN] = 0x7d, >> >> Current linux can't use set1, so untested. > > Note that those are the same as

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-27 Thread Hervé Poussineau
Le 23/12/2016 à 23:49, OGAWA Hirofumi a écrit : Hi, Hervé Poussineau writes: [from ui/input-keymap.c] [Q_KEY_CODE_RO] = 0x73, +[Q_KEY_CODE_HIRAGANA] = 0x70, +[Q_KEY_CODE_HENKAN] = 0x79, +[Q_KEY_CODE_YEN] = 0x7d, [Q_KEY_CODE_KP_COMMA] = 0x7e, [Q_KEY_CODE__MAX] = 0,

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
Eric Blake writes: > On 12/23/2016 07:00 AM, OGAWA Hirofumi wrote: >> >> With "ps2: use QEMU qcodes instead of scancodes", key handling was >> changed to qcode base. But all scancodes are not converted to new one. >> >> This adds some missing qcodes what I found in using. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
Hi, Hervé Poussineau writes: >> [Q_KEY_CODE_RO] = 0x73, >> +[Q_KEY_CODE_HIRAGANA] = 0x70, >> +[Q_KEY_CODE_HENKAN] = 0x79, >> +[Q_KEY_CODE_YEN] = 0x7d, >> [Q_KEY_CODE_KP_COMMA] = 0x7e, >> >> [Q_KEY_CODE__MAX] = 0, > > Can you also add the keycodes for scancode set 1: >

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread Eric Blake
On 12/23/2016 07:00 AM, OGAWA Hirofumi wrote: > > With "ps2: use QEMU qcodes instead of scancodes", key handling was > changed to qcode base. But all scancodes are not converted to new one. > > This adds some missing qcodes what I found in using. > > Signed-off-by: OGAWA Hirofumi > --- > > ++

Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread Hervé Poussineau
Le 23/12/2016 à 14:00, OGAWA Hirofumi a écrit : With "ps2: use QEMU qcodes instead of scancodes", key handling was changed to qcode base. But all scancodes are not converted to new one. This adds some missing qcodes what I found in using. Signed-off-by: OGAWA Hirofumi --- hw/input/ps2.c

[Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes

2016-12-23 Thread OGAWA Hirofumi
With "ps2: use QEMU qcodes instead of scancodes", key handling was changed to qcode base. But all scancodes are not converted to new one. This adds some missing qcodes what I found in using. Signed-off-by: OGAWA Hirofumi --- hw/input/ps2.c|3 +++ qapi-schema.json |3 ++- ui/input