Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-04 Thread David Gibson
On Mon, Feb 04, 2019 at 10:10:05AM +, Daniel P. Berrangé wrote: > On Mon, Feb 04, 2019 at 12:09:04PM +1100, David Gibson wrote: > > On Sat, Feb 02, 2019 at 12:23:58AM +0530, P J P wrote: > > > From: Prasad J Pandit > > > > > > On ppc hosts, hypervisor shares following system attributes > > >

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-04 Thread Daniel P . Berrangé
On Sat, Feb 02, 2019 at 12:23:58AM +0530, P J P wrote: > From: Prasad J Pandit > > On ppc hosts, hypervisor shares following system attributes > > - /proc/device-tree/system-id > - /proc/device-tree/model > > with a guest. This could lead to information leakage and misuse.[*] > Add machine

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-04 Thread Daniel P . Berrangé
On Mon, Feb 04, 2019 at 12:09:04PM +1100, David Gibson wrote: > On Sat, Feb 02, 2019 at 12:23:58AM +0530, P J P wrote: > > From: Prasad J Pandit > > > > On ppc hosts, hypervisor shares following system attributes > > > > - /proc/device-tree/system-id > > - /proc/device-tree/model > > > > wi

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-03 Thread P J P
+-- On Mon, 4 Feb 2019, David Gibson wrote --+ | On Mon, Feb 04, 2019 at 11:40:46AM +0530, P J P wrote: | > Ie. make the default behaviour host-serial/host-model=NULL/none, instead of | > 'passthrough' now? | | Yes. | Okay, I'll send a revised patch. Thank you. -- Prasad J Pandit / Red Hat Produ

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-03 Thread David Gibson
On Mon, Feb 04, 2019 at 11:40:46AM +0530, P J P wrote: > +-- On Mon, 4 Feb 2019, David Gibson wrote --+ > | I'm wondering if we can just ditch them entirely, or at least make > | them default to not present without regard to machine version. > > Ie. make the default behaviour host-serial/host-mode

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-03 Thread P J P
+-- On Mon, 4 Feb 2019, David Gibson wrote --+ | I'm wondering if we can just ditch them entirely, or at least make | them default to not present without regard to machine version. Ie. make the default behaviour host-serial/host-model=NULL/none, instead of 'passthrough' now? Thank you. -- Prasad

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-03 Thread David Gibson
On Sat, Feb 02, 2019 at 12:23:58AM +0530, P J P wrote: > From: Prasad J Pandit > > On ppc hosts, hypervisor shares following system attributes > > - /proc/device-tree/system-id > - /proc/device-tree/model > > with a guest. This could lead to information leakage and misuse.[*] > Add machine

Re: [Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201185358.6972-1-ppan...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-01 Thread P J P
From: Prasad J Pandit On ppc hosts, hypervisor shares following system attributes - /proc/device-tree/system-id - /proc/device-tree/model with a guest. This could lead to information leakage and misuse.[*] Add machine attributes to control such system information exposure to a guest. [*] h