Re: [Qemu-devel] [PATCH] ppc: Use FPSCR defines instead of constants

2019-09-18 Thread David Gibson
On Wed, Sep 18, 2019 at 09:32:49AM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > There are FPSCR-related defines in target/ppc/cpu.h which can be used in > place of constants and explicit shifts which arguably improve the code a > bit in places. > > Signed-off-by: Paul A. Clarke Ap

Re: [Qemu-devel] [PATCH] ppc: Use FPSCR defines instead of constants

2019-09-18 Thread Richard Henderson
On 9/18/19 7:32 AM, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > There are FPSCR-related defines in target/ppc/cpu.h which can be used in > place of constants and explicit shifts which arguably improve the code a > bit in places. > > Signed-off-by: Paul A. Clarke > --- > I confirmed that

[Qemu-devel] [PATCH] ppc: Use FPSCR defines instead of constants

2019-09-18 Thread Paul A. Clarke
From: "Paul A. Clarke" There are FPSCR-related defines in target/ppc/cpu.h which can be used in place of constants and explicit shifts which arguably improve the code a bit in places. Signed-off-by: Paul A. Clarke --- I confirmed that the generated assembly is identical before and after the pat