Re: [Qemu-devel] [PATCH] ppc/xics: fix XICSStateClass parent class

2017-02-14 Thread David Gibson
On Tue, Feb 14, 2017 at 07:25:07AM +0100, Cédric Le Goater wrote: > On 02/14/2017 02:58 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 10:33:24AM +0100, Cédric Le Goater wrote: > >> XICSState inherits from SysBusDevice and so the object class should > >> inherit from SysBusDeviceClass. > >> >

Re: [Qemu-devel] [PATCH] ppc/xics: fix XICSStateClass parent class

2017-02-13 Thread Cédric Le Goater
On 02/14/2017 02:58 AM, David Gibson wrote: > On Mon, Feb 13, 2017 at 10:33:24AM +0100, Cédric Le Goater wrote: >> XICSState inherits from SysBusDevice and so the object class should >> inherit from SysBusDeviceClass. >> >> Signed-off-by: Cédric Le Goater > > That's definitely a bug, but I don't

Re: [Qemu-devel] [PATCH] ppc/xics: fix XICSStateClass parent class

2017-02-13 Thread David Gibson
On Mon, Feb 13, 2017 at 10:33:24AM +0100, Cédric Le Goater wrote: > XICSState inherits from SysBusDevice and so the object class should > inherit from SysBusDeviceClass. > > Signed-off-by: Cédric Le Goater That's definitely a bug, but I don't think this is the right fix. XICS was put on sysbus

[Qemu-devel] [PATCH] ppc/xics: fix XICSStateClass parent class

2017-02-13 Thread Cédric Le Goater
XICSState inherits from SysBusDevice and so the object class should inherit from SysBusDeviceClass. Signed-off-by: Cédric Le Goater --- include/hw/ppc/xics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 3f0c31610aa4..e879