Re: [Qemu-devel] [PATCH] ppc/xics: fix ICP reset path

2018-07-23 Thread Greg Kurz
On Mon, 23 Jul 2018 13:36:36 +0200 Cédric Le Goater wrote: > On 07/12/2018 12:01 PM, Greg Kurz wrote: > > Recent cleanup in commit a028dd423ee6 dropped the ICPStateClass::reset > > handler. It is now up to child ICP classes to call the DeviceClass::reset > > handler of the parent class, thanks to

Re: [Qemu-devel] [PATCH] ppc/xics: fix ICP reset path

2018-07-23 Thread Cédric Le Goater
On 07/12/2018 12:01 PM, Greg Kurz wrote: > Recent cleanup in commit a028dd423ee6 dropped the ICPStateClass::reset > handler. It is now up to child ICP classes to call the DeviceClass::reset > handler of the parent class, thanks to device_class_set_parent_reset(). > This is a better object programmi

Re: [Qemu-devel] [PATCH] ppc/xics: fix ICP reset path

2018-07-12 Thread David Gibson
On Thu, Jul 12, 2018 at 12:01:49PM +0200, Greg Kurz wrote: > Recent cleanup in commit a028dd423ee6 dropped the ICPStateClass::reset > handler. It is now up to child ICP classes to call the DeviceClass::reset > handler of the parent class, thanks to device_class_set_parent_reset(). > This is a bette

[Qemu-devel] [PATCH] ppc/xics: fix ICP reset path

2018-07-12 Thread Greg Kurz
Recent cleanup in commit a028dd423ee6 dropped the ICPStateClass::reset handler. It is now up to child ICP classes to call the DeviceClass::reset handler of the parent class, thanks to device_class_set_parent_reset(). This is a better object programming pattern, but unfortunately it causes QEMU to c