Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-06 Thread David Gibson
On Mon, Mar 06, 2017 at 08:56:07AM +0100, Cédric Le Goater wrote: > On 03/06/2017 12:23 AM, David Gibson wrote: > > On Fri, Mar 03, 2017 at 06:23:15PM +0100, Cédric Le Goater wrote: > >> On 03/03/2017 05:54 PM, Thomas Huth wrote: > >>> On 03.03.2017 15:49, Cédric Le Goater wrote: > On 03/03/20

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-05 Thread Cédric Le Goater
On 03/06/2017 12:23 AM, David Gibson wrote: > On Fri, Mar 03, 2017 at 06:23:15PM +0100, Cédric Le Goater wrote: >> On 03/03/2017 05:54 PM, Thomas Huth wrote: >>> On 03.03.2017 15:49, Cédric Le Goater wrote: On 03/03/2017 03:13 PM, Thomas Huth wrote: > On 03.03.2017 14:37, Cédric Le Goater

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-05 Thread David Gibson
On Fri, Mar 03, 2017 at 06:23:15PM +0100, Cédric Le Goater wrote: > On 03/03/2017 05:54 PM, Thomas Huth wrote: > > On 03.03.2017 15:49, Cédric Le Goater wrote: > >> On 03/03/2017 03:13 PM, Thomas Huth wrote: > >>> On 03.03.2017 14:37, Cédric Le Goater wrote: > Also use an 'Object *' under the

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-03 Thread Cédric Le Goater
On 03/03/2017 05:54 PM, Thomas Huth wrote: > On 03.03.2017 15:49, Cédric Le Goater wrote: >> On 03/03/2017 03:13 PM, Thomas Huth wrote: >>> On 03.03.2017 14:37, Cédric Le Goater wrote: Also use an 'Object *' under the sPAPR machine to hold the RTC object. >>> >>> The change from TYPE_SYS_

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-03 Thread Thomas Huth
On 03.03.2017 15:49, Cédric Le Goater wrote: > On 03/03/2017 03:13 PM, Thomas Huth wrote: >> On 03.03.2017 14:37, Cédric Le Goater wrote: >>> Also use an 'Object *' under the sPAPR machine to hold the RTC >>> object. >> >> The change from TYPE_SYS_BUS_DEVICE to TYPE_DEVICE is certainly a good >> id

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-03 Thread Cédric Le Goater
On 03/03/2017 03:13 PM, Thomas Huth wrote: > On 03.03.2017 14:37, Cédric Le Goater wrote: >> Also use an 'Object *' under the sPAPR machine to hold the RTC >> object. > > The change from TYPE_SYS_BUS_DEVICE to TYPE_DEVICE is certainly a good > idea! But what's the advantage of using Object* instea

Re: [Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-03 Thread Thomas Huth
On 03.03.2017 14:37, Cédric Le Goater wrote: > Also use an 'Object *' under the sPAPR machine to hold the RTC > object. The change from TYPE_SYS_BUS_DEVICE to TYPE_DEVICE is certainly a good idea! But what's the advantage of using Object* instead of DeviceState* in sPAPRMachineState ? Thomas

[Qemu-devel] [PATCH] ppc/spapr: QOM'ify sPAPRRTCState

2017-03-03 Thread Cédric Le Goater
Also use an 'Object *' under the sPAPR machine to hold the RTC object. Overall, these changes remove an unnecessary and implicit dependency on SysBus. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 12 +++- hw/ppc/spapr_rtc.c | 10 +- include/hw/ppc/spapr.h