Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix idle_threads counter

2011-05-04 Thread Stefan Hajnoczi
On Tue, May 3, 2011 at 5:53 PM, Kevin Wolf wrote: > Am 03.05.2011 17:56, schrieb Stefan Hajnoczi: >> On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote: >>> A thread should only be counted as idle when it really is waiting for new >>> requests. Without this patch, sometimes too few threads are star

Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix idle_threads counter

2011-05-03 Thread Kevin Wolf
Am 03.05.2011 17:56, schrieb Stefan Hajnoczi: > On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote: >> A thread should only be counted as idle when it really is waiting for new >> requests. Without this patch, sometimes too few threads are started as busy >> threads are counted as idle. >> >> Not su

Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix idle_threads counter

2011-05-03 Thread Stefan Hajnoczi
On Tue, May 3, 2011 at 2:26 PM, Kevin Wolf wrote: > A thread should only be counted as idle when it really is waiting for new > requests. Without this patch, sometimes too few threads are started as busy > threads are counted as idle. > > Not sure if it makes a difference in practice outside some

[Qemu-devel] [PATCH] posix-aio-compat: Fix idle_threads counter

2011-05-03 Thread Kevin Wolf
A thread should only be counted as idle when it really is waiting for new requests. Without this patch, sometimes too few threads are started as busy threads are counted as idle. Not sure if it makes a difference in practice outside some artificial qemu-io/qemu-img tests, but I think the change ma