Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix error check

2009-11-18 Thread Christoph Hellwig
On Wed, Nov 18, 2009 at 12:15:10PM +0100, Kevin Wolf wrote: > Checking for nbytes < 0 is pointless as long as it's a size_t. If we want to > use negative numbers for error codes, we should use signed types. Indeed, patch looks good. Reviewed-by: Christoph Hellwig

[Qemu-devel] [PATCH] posix-aio-compat: Fix error check

2009-11-18 Thread Kevin Wolf
Checking for nbytes < 0 is pointless as long as it's a size_t. If we want to use negative numbers for error codes, we should use signed types. Signed-off-by: Kevin Wolf --- posix-aio-compat.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/posix-aio-comp