Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.05.2019 um 13:59 hat Markus Armbruster geschrieben: >> Xiang Zheng writes: >> >> > On 2019/5/10 23:16, Markus Armbruster wrote: >> >> Xiang Zheng writes: >> >> >> >>> On 2019/5/9 19:59, Markus Armbruster wrote: >> Xiang Zheng writes: >> >> > On 2019/5

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-13 Thread Kevin Wolf
Am 13.05.2019 um 13:59 hat Markus Armbruster geschrieben: > Xiang Zheng writes: > > > On 2019/5/10 23:16, Markus Armbruster wrote: > >> Xiang Zheng writes: > >> > >>> On 2019/5/9 19:59, Markus Armbruster wrote: > Xiang Zheng writes: > > > On 2019/5/8 21:20, Markus Armbruster wrot

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-13 Thread Markus Armbruster
Xiang Zheng writes: > On 2019/5/10 23:16, Markus Armbruster wrote: >> Xiang Zheng writes: >> >>> On 2019/5/9 19:59, Markus Armbruster wrote: Xiang Zheng writes: > On 2019/5/8 21:20, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> Hi Markus, >>> >>> On

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-11 Thread Xiang Zheng
On 2019/5/10 23:16, Markus Armbruster wrote: > Xiang Zheng writes: > >> On 2019/5/9 19:59, Markus Armbruster wrote: >>> Xiang Zheng writes: >>> On 2019/5/8 21:20, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Hi Markus, >> >> On 05/07/19 20:01, Markus Armbruste

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-10 Thread Markus Armbruster
Xiang Zheng writes: > On 2019/5/9 19:59, Markus Armbruster wrote: >> Xiang Zheng writes: >> >>> On 2019/5/8 21:20, Markus Armbruster wrote: Laszlo Ersek writes: > Hi Markus, > > On 05/07/19 20:01, Markus Armbruster wrote: >> The subject is slightly misleading. Holes

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-10 Thread Xiang Zheng
On 2019/5/9 19:59, Markus Armbruster wrote: > Xiang Zheng writes: > >> On 2019/5/8 21:20, Markus Armbruster wrote: >>> Laszlo Ersek writes: >>> Hi Markus, On 05/07/19 20:01, Markus Armbruster wrote: > The subject is slightly misleading. Holes read as zero. So do > non

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-09 Thread Markus Armbruster
Xiang Zheng writes: > On 2019/5/8 21:20, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> Hi Markus, >>> >>> On 05/07/19 20:01, Markus Armbruster wrote: The subject is slightly misleading. Holes read as zero. So do non-holes full of zeroes. The patch avoids reading the forme

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-09 Thread Xiang Zheng
On 2019/5/8 21:20, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Hi Markus, >> >> On 05/07/19 20:01, Markus Armbruster wrote: >>> The subject is slightly misleading. Holes read as zero. So do >>> non-holes full of zeroes. The patch avoids reading the former, but >>> still reads the l

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-08 Thread Markus Armbruster
Laszlo Ersek writes: > Hi Markus, > > On 05/07/19 20:01, Markus Armbruster wrote: >> The subject is slightly misleading. Holes read as zero. So do >> non-holes full of zeroes. The patch avoids reading the former, but >> still reads the latter. >> >> Xiang Zheng writes: >> >>> Currently we f

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-07 Thread Laszlo Ersek
Hi Markus, On 05/07/19 20:01, Markus Armbruster wrote: > The subject is slightly misleading. Holes read as zero. So do > non-holes full of zeroes. The patch avoids reading the former, but > still reads the latter. > > Xiang Zheng writes: > >> Currently we fill the memory space with two 64MB

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-07 Thread Markus Armbruster
The subject is slightly misleading. Holes read as zero. So do non-holes full of zeroes. The patch avoids reading the former, but still reads the latter. Xiang Zheng writes: > Currently we fill the memory space with two 64MB NOR images when > using persistent UEFI variables on virt board. Actu

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-05 Thread Xiang Zheng
On 2019/5/5 23:37, Peter Maydell wrote: > On Sun, 5 May 2019 at 08:02, Xiang Zheng wrote: >> >> Currently we fill the memory space with two 64MB NOR images when >> using persistent UEFI variables on virt board. Actually we only use >> a very small(non-zero) part of the memory while the rest sign

Re: [Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-05 Thread Peter Maydell
On Sun, 5 May 2019 at 08:02, Xiang Zheng wrote: > > Currently we fill the memory space with two 64MB NOR images when > using persistent UEFI variables on virt board. Actually we only use > a very small(non-zero) part of the memory while the rest significant > large(zero) part of memory is wasted.

[Qemu-devel] [PATCH] pflash: Only read non-zero parts of backend image

2019-05-05 Thread Xiang Zheng
Currently we fill the memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a very small(non-zero) part of the memory while the rest significant large(zero) part of memory is wasted. So this patch checks the block status and only writes the