Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-20 Thread Peter Maydell
On 19 September 2012 21:51, Stefan Weil wrote: > Am 19.09.2012 18:45, schrieb Peter Maydell: >> ...shouldn't we be propagating the write error up to the guest? >> It feels like this change is just silencing the coverity error >> without actually fixing the underlying problem. > As far as I know,

Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-19 Thread Stefan Weil
Am 19.09.2012 18:45, schrieb Peter Maydell: On 19 September 2012 17:41, Stefan Weil wrote: hw/pflash_cfi01.c:209: check_return: Calling function "bdrv_write" without checking return value (as is done elsewhere 35 out of 37 times). hw/pflash_cfi02.c:144: unterminated_default: The default case

Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-19 Thread Peter Maydell
On 19 September 2012 17:41, Stefan Weil wrote: > hw/pflash_cfi01.c:209: > check_return: Calling function "bdrv_write" without checking return value (as > is done elsewhere 35 out of 37 times). > > hw/pflash_cfi02.c:144: > unterminated_default: The default case is not terminated by a 'break' > st

[Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-19 Thread Stefan Weil
hw/pflash_cfi01.c:209: check_return: Calling function "bdrv_write" without checking return value (as is done elsewhere 35 out of 37 times). hw/pflash_cfi02.c:144: unterminated_default: The default case is not terminated by a 'break' statement. hw/pflash_cfi02.c:238: check_return: Calling functio