Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

2014-08-19 Thread Gonglei (Arei)
rkin > Subject: Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds > > On Tue, Aug 19, 2014 at 5:18 PM, wrote: > > From: Gonglei > > > > When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the > > s->acpi_pcihp_pci_status[bsel] array will

Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

2014-08-19 Thread Gonglei (Arei)
> -Original Message- > From: Marcel Apfelbaum [mailto:marcel.apfelb...@gmail.com] > Sent: Tuesday, August 19, 2014 11:00 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Huangweidong (C); m...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] pcihp: fix possible a

Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

2014-08-19 Thread Peter Crosthwaite
On Tue, Aug 19, 2014 at 5:18 PM, wrote: > From: Gonglei > > When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the > s->acpi_pcihp_pci_status[bsel] array will out of bounds. > > Add check for this. > > Signed-off-by: Gonglei Reviewed-by: Peter Crosthwaite > --- > hw/acpi/pcihp.c | 2 +- > 1 file ch

Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

2014-08-19 Thread Marcel Apfelbaum
On Tue, 2014-08-19 at 15:18 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the > s->acpi_pcihp_pci_status[bsel] array will out of bounds. I would change the commit message to something like "Prevent out-of-bounds array access on acpi_pcihp_pci

[Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

2014-08-19 Thread arei.gonglei
From: Gonglei When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the s->acpi_pcihp_pci_status[bsel] array will out of bounds. Add check for this. Signed-off-by: Gonglei --- hw/acpi/pcihp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index fae6